Develop Reference

My ID field is getting a value when it shouldn't be

In my [HttpGet] Create Action I have this:
public ActionResult Create(int? id)
{
ViewBag.TestTypeID = new SelectList(db.codeTypes, "ID", "TestType");
OHealth oHealth = new OHealth();
oHealth.OID = Convert.ToInt32(id);
oHealth.DateEntered = DateTime.Today;
return View(oHealth);
}
Now, OID is a foreign key, not the primary key ID. As you can see I don't assign ID any value.. only OID. ID is auto-incremented in the database.
Here is how my HTML renders for my Create View for OID and ID:
<input data-val="true" data-val-number="The field ID must be a number." data-val-required="The ID field is required." id="ID" name="ID" type="hidden" value="2" />
<input data-val="true" data-val-number="The field OID must be a number." data-val-required="The OID field is required." id="OID" name="OID" type="hidden" value="2" />
So when I hit create, the ID field is given the value of 2 when it should be 1 since it will be the first record in the database.
How is my ID field receiving a value of 2 when that hasn't been assigned?
Let me know if more is needed.
Any help is appreciated.
UPDATE
Razor for those 2 fields:
#Html.HiddenFor(model => model.ID)
#Html.HiddenFor(model => model.OID)

MVC automatically binds parameters into the modelstate. So your parameter id in:
public ActionResult Create(int? id)
will be automatically put into Model.ID (as url params are case-insensitive).
You should be able to confirm this by changing the name of the parameter (and corresponding url/action definition), eg:
public ActionResult Create(int? anotherid)
and change the url from /Create/2 to /Create?anotherid=2
This occurs automatically so that any values in a POST will automatically have the same values they had when the form was posted without you needing to explicitly set them. In a GET this occurs from the parameters.
The fix is to add ModelState.Clear():
public ActionResult Create(int? id)
{
if (!ModelState.IsValid) return;
ModelState.Clear();
this will stop the auto-rebinding when the view fields are regenerated.
The re-binding occurs after the view has been generated, all the field values are re-inserted from ModelState. By clearing modelstate, you stop this from happening.

ASP.Net MVC TextBoxFor ignore my format

I create some helper method and create TextBoxFor inside it.
input.AppendLine(html.TextBoxFor(expression, format, attributes).ToString());
My format was "{0:dd/MM/yyyy}". It's work totally fine and render as
<input class="form-control req" data-val="true" data-val-date="The field detr must be a date." id="detr" name="detr" type="text" value="25/05/2558" />
But when ModelState has error on this field, TextBoxFor was totally ignore my format and rendered as
<input class="input-validation-error form-control req" data-val="true" data-val-date="The field detr must be a date." id="detr" name="detr" type="text" value="28/5/2558 0:00:00" />
What happened here?
How can I fixed this?
Thank you in advance.

I finally found source of this strange phenomenon.
It's happend when i use FluentValidator and explicitly call
validator.validate(obj)
When i add it's into ModelState, ModelState's property RawValue data type was DateTime. and that mess everything up. (if not explicitly call but set validator as class attribute RawValue data type will be string)
So I found 2 ways to fix this problem.
1st: Just set validator as class attribute and not explicitly call validator.
[FluentValidation.Attributes.Validator(typeof(objValidator))]
2nd: Create new ModelState and manually add model error.
var _validator = new ObjValidator();
var results = _validator.Validate(dto);
ModelStateDictionary modelStateDicts = new ModelStateDictionary();
foreach (KeyValuePair<string, ModelState> kv in ModelState.Where(x => results.Errors.Count(y => y.PropertyName == x.Key) > 0))
{
modelStateDicts.AddModelError(kv.Key, results.Errors.FirstOrDefault(x=>x.PropertyName == kv.Key).ErrorMessage);
}

Id POST as hidden field but null in controller

I have a form:
#using (Html.BeginForm("QuoteUpdate", "Home", FormMethod.Post))
{
#Html.DropDownList("network", Model.availableNetworks);
#Html.DropDownList("grade", Model.grades);
#Html.HiddenFor(o => o.Product.id);
<button type="submit">Get Quote</button>
}
And a controller:
[HttpPost]
public ActionResult QuoteUpdate(int? id, string network, string grade )
{
}
The id property is always null after form is submitted. I have checked source and the hidden field has the correct value in the rendered HTML.
I cannot figure out why this parameter is always null. What am I missing?

Since you're accessing a nested property on your model, the generated HTML is probably something like this:
<input type="hidden" id="Product_id" name="Product.id" />
When your form gets posted to the controller action, there's not a parameter that matches up with Product.Id.
You could work around this by changing the generated name of the input (see this answer for more about how to do that):
#Html.HiddenFor(o => o.Product.id, new { Name = "id" });
Which will generate:
<input type="hidden" id="Product_id" name="id" />
Then things should model bind correctly.

MVC 4 : Postback returns a array for property of type object in my model

I have a model with one of the property of type object . This property is a dynamic property and could sometime contain a string or a date or a Boolean.
I have a editor template for each type i.e boolean , string , date etc .
The problem I have is when the page is posted , the postback contains a array instead of the actual value. The first element of the array contains the actual value.
Why is the value being returned as a array ?
My model
public string Description;
public string Name { get; set; }
public Type Type{ get; set; }
object _value;
public object Value { get;set;}
statement in the view
#Html.EditorFor( m => m.Value)
Edit : Corrected the object name from _value to Value. It was a wrong Ctrl V operation.
Edit : The HTML rendered in the browser
When the object contain a boolean value (checkbox):
<div>
<input checked="checked" data-val="true" data-val-required="The BoolJPY field is required." id="FurtherInformationFieldObject_Properties_1__Value" name="FurtherInformationFieldObject.Properties[1].Value" type="checkbox" value="true"><input name="FurtherInformationFieldObject.Properties[1].Value" type="hidden" value="false">
When the object contains a string(Textbox) :
<div id="divStringField"><input class="text-box single-line valid" data-val="true" data-val-required="The String Field field is required." id="FurtherInformationFieldObject_Properties_2__Value" name="FurtherInformationFieldObject.Properties[2].Value" type="text" value=""> </div>
Edit 2 : Posting the complete model and view code.
Controller code :
public ActionResult Edit(string name ="field1" )
{
Models.DynamicData data1 = new Models.DynamicData();
//all this comes from the database table. I am putting the value directly in field just for simplicity
// this is exactly how I convert the value from the entity to the model
data1.Description = "Field1 Description";
data1.Name = "field1";
data1.Type = typeof(string);
data1.Value = Convert.ChangeType("MyStringValue", data1.Type);
//similarly add few more fields to the model collection
return View(data1);
}
[HttpPost]
public ActionResult Edit(Models.DynamicData model)
{
// break point here : model.Value shows a array of string instead of the edited value.
return View(model);
}
View :
#model SampleDynamicDataProject.Models.DynamicData
#{
ViewBag.Title = "Edit";
}
<h2>Edit</h2>
#using (Html.BeginForm()) {
#Html.AntiForgeryToken()
#Html.ValidationSummary(true)
<fieldset>
<legend>DynamicData</legend>
<div class="editor-label">
#Model.Description
</div>
<div class="editor-field">
#Html.EditorFor(model => model.Value)
#Html.ValidationMessageFor(model => model.Value)
</div>
<p>
<input type="submit" value="Save" />
</p>
</fieldset>
}
I should explain I used object as type for Value property because the value could be string or bool or date ex data1 in above controller could look like below
data1.Description = "Field2 Description";
data1.Name = "field2";
data1.Type = typeof(bool);
data1.Value = Convert.ChangeType("true", data1.Type); // database stores "true" as string which is converted into a boolean and stored in the object.
As shown in the code , my problem is in the post action for Edit , I get Value as an array even for a simple string.
The sample project code here https://drive.google.com/file/d/0B3xCaeRk2IQZSTM0aHdoWEtNYW8/edit?usp=sharing

I got a answer to my question at one of the other forums.
Basically the reason MVC binder is returning a array is because it does not understand what type of data/control is used in the html and the model binder fails.
I got around my issue by modifying the model to have two different property a
public String StringValue
public Bool BooleanValue
I use the StringValue field when the Type is String , Date , Number etc.
I use the BooleanValue for field with Type as Boolean.
Its not the cleanest approach but it will have to do till the point I write my own custom model binder.
Thanks to bruce who answered my question here http://forums.asp.net/p/1961776/5605374.aspx?Re+MVC+4+Postback+returns+a+array+for+property+of+type+object+in+my+model
I now understand why the model binder fails.
Pasting his answer here for the benefit of others
you need to understand how browser postback is done. on form submit a collection of name/value pairs is sent. the name is the form element name, the value is the elements value. standard url encoding is done. so for:
the postdata is
foo=1&bar=true
note the post data is just a string with no type data. the brwser allows duplicate name, so
the post data is:
foo=1&foo=true
when asp.net load the post data into the form collection (which is just a dictionary), it can not add the key "foo" twice, but concats the values seperated by a "," ("1,true"). the binder just treats it as a string array named foo with 2 values.
now we get to another browser behavior. form elements that support checked (radio and checkbox) are only include the post data if checked. this causes a problem for the mvc binder with checkbox, becuase it can not tell from the postback data if the element was not checked or not included. this is important if you are using tryupdate to apply only a subset of the model properties, becuase only a subset was rendered. to get around this, the checkbox helper renders two fields with the same name, a hidden with the value "false" and a checkbox with the value "true".

MVC3 - HiddenFor Dictionary Values

I have a dictionary property called Week:
public IDictionary<DayOfWeek, Day> Week { get; private set; }
And I'm trying to pass its values off to HiddenFor (Days)
#Html.HiddenFor(x => x.Week.Values)
It has to be a property of the Model so I can't do x.Week.Values.ToList();
How would I go about passing the Dictionary Values to the Html.HiddenFor?

Well since your using HiddenFor, I'm going to assume that you need to rebind the values of the dictionary on form post. To bind a Dictionary to the view, your going to need to do something like this:
#foreach (var key in Model.Week.Keys)
{
Html.DisplayFor(model=>model.Week[key]);
}
Each value in the dictionary will be given its own Hidden Input field, with the name attribute:
name="Week.{key here}
If, on the other hand, all you need to do is send the data in your model to the client so that you can do something with it in JavaScript, you might want to look at writing it to the page as JSON.
<script type="text/javascript">
#Html.Raw(Json.Encode(Model.Week))
</script>

I would use:
#foreach (var key in Model.Week.Keys)
{
#Html.HiddenFor(model=>model.Week[key]);
}
The '#' before the Html seems necessary for razor to output the hidden fields.
It outputs something like this for each key:
<input data-val="true" data-val-number="The field Int32 must be a number."
data-val-required="The Int32 field is required." id="Week_5_" name="Week[5]"
type="hidden" value="3">