I have 2 windowsForms lets call them form1 and form2. form1 consists of a picturebox and a button. When I click on the button form2 opens. Now form2 consists of a grid and depending on the position on which I have clicked on the grid the x and y coordinates are returned to form1. Based on these coordinates I add an image to the pictureBox. But the image isn't getting added! Is there something I am missing here?
Code inside the mouseDownEvent in form2
Form1 f1 = new Form1();
f1.openImage(x,y);
Code in form1
internal void openImage(int x, int y)
{
string ogFileName = "r" + x.ToString() + "c" + y.ToString();
string imageFilePath = ogFileName + "." + extension;
MessageBox.Show(imageFilePath); //I can see the correct path here
pictureBox1.Image = Image.FromFile(imageFilePath);
}//extension is a static variable declared outside this function.
Form1 f1 = new Form1();
This line only creates a new instance of Form1
What you can do is adding a Form1 variable which will reference your current form.
You initialize it in constructor and in the button click you pass it to Form2
public partial class Form1 : Form
{
Form1 form1; // form1 will store the reference of Form1
public Form1()
{
form1 = this; // We initialize form1 in the constructor
InitializeComponent();
}
// button to open form2
private void button1_Click(object sender, EventArgs e)
{
Form2 form2 = new Form2(form1); // We open form2 with form1 as parameter
form2.Visible = true;
}
public void openImage(int x, int y)
{
}
}
Now in the Form2 you just have to add a Form1 variable that will be initialized in the constructor.
Then you can use it as now it represents the current instance of Form1
public partial class Form2 : Form
{
Form1 form1; // Reference to form1
public Form2(Form1 form1)
{
this.form1 = form1; // We initialize form1
InitializeComponent();
}
private void button1_Click(object sender, EventArgs e)
{
// we call openimage from form1
form1.openImage(130, 140);
}
}
I have tested this example with a label and it works fine so I think there should be no problem with a picturebox
Related
In Form1 I have one DataGridView and multiple textboxes. When I click A button in Form2 I need to save the data from DataGridView and multiple textboxes to Database. How to Implement in C sharp Windows Application
Form1 Button Click event. I opened Form2
public sealed partial class form1 : Form
{
private static form1 instance = null;
public static form1 Instance
{
get
{
if (instance == null)
{
instance = new form1();
}
return instance;
}
}
private void button1_Click(object sender, EventArgs e)
{
textbox2.Text=100;
form2 CO = new form2();
CO.Show();
}
}
I want to attach textboxes data and Datagridview content to
object SO and Call InsertSale function .textboxes and datagridview are in form1
This is Button Click Event in Form 2
private void button1_Click(object sender, EventArgs e)
{
clsSale SO = new clsSale();
SO.Totamount = Convert.ToDecimal(form1.Instance.textBox2.Text);
SO.InserSale(SO);
}
If Form2 wants to access the Form1 properties.
Pass ParentForm instance to the ChildForm constructor. Add a public method in the parent form to update its properties from child form.
public partial class Form1: Form
{
public Form1()
{
InitializeComponent();
}
public void SetTextBoxValue(string val)
{
this.textBox1.Text = val;
}
private void CreateForm2()
{
var form2 = new Form2(this);
form2.Show();
}
}
public partial class Form2: Form
{
private Form1 form1;
public Form2(Form1 frm1)
{
InitializeComponent();
form1= frm1;
form1.SetTextBoxValue("Value from Form2");
}
}
Create a global class, such as Global.cs, in the project. Then declare the following variables:
public static Form1 frm1
public static Form2 frm2
Declare a variable of the Form class - Form frm1 or Form frm2 etc.
Now access the variables from any form as follows:
Global.frm1 = new Form1() // - for the Home Form1
Global.frm1.ShowDialog();
Global.frm2 = new Form2() // - for the Home Form1
Global.frm2.ShowDialog();
If you want to access a control in any form, just extend them as follows:
frm1.txtBox1.Text
frm2.button1.Click() // etc.
I use Form.Show() to open a new form
Like this:
public Form2()
{
Form1 fm = new Form1();
fm.Show();
}
How do I get Form2's name when Form1 has control?
What I am doing is create a public variable(ex.pFormname) in From1
and set pFormname = Form2 before the show common like this:
public Form2()
{
Form1.pFormname = "Form2";
Form1 fm = new Form1();
fm.Show();
}
Is there any other way except creating a public variable?
And is there any resource release should I do after closing Form1?
public Form2()
{
Form1 fm = new Form1();
Form1.pFormname = this.Text; // this = Form2, Text = the arbitrary name of the form.
fm.Show();
}
This requires you to have a public instance variable or property called pFormname in Form1 class. the 'this' keyword represents the current instance of Form2, and Text is the property which contains the name of the Form.
If you want to access other properties on the parent form, you could pass it as a reference when you instantiate Form1.
public Form2()
{
Form1 fm = new Form1(this); // this = form2.
fm.Show();
}
In Form1 you would have something like this:
public partial class Form1 : Form
{
private Form2 _parentForm;
public Form1(Form2 parentForm)
{
_parentForm = parentForm;
InitializeComponent();
}
}
And you would call public variables/properties/methods like this:
_parentForm.SomeMethod();
You could use the forms Owner property and pick that up in your instance later. For example in the constructor of Form2:
public Form2()
{
Form1 fm = new Form1 {Owner=this};
fm.Show();
}
You use the Owner name in Form1 like this
public class Form1 : Form
{
public Form1()
{
InitializeComponent();
this.Load += Form1_Load;
}
void Form1_Load(object sender, EventArgs e)
{
label1.Text += Owner.Name;
}
}
If you want to find the name of the parent form , you can do so by using
string s = ParentForm.Name; // s will contain the name of the parent form
Hope this helps..
If you want to find out , the child ..you can do so by:
MdiChildren property.
this will help you to find out , which child forms(Form 2) are contained by currently opened form(Form1).
Refer to this for how to use this exactly:
http://msdn.microsoft.com/en-us/library/system.windows.forms.form.mdichildren(v=vs.110).aspx
The best thing you can do in that situation is to have a private field in Form1 and set it equal to Form2 when you instantiate it like this.
class Form1 : Form
{
private Form _parentForm;
public Form1(Form f)
{
_parentForm = f;
}
}
and when you instantiate Form1 do like this
Form1 fm = new Form1(this) // in the constructor of Form2;
after this you will have the reference to the Form2 in the Form1's _parentForm variable and you can easuily access any of its properties for instance;
MessageBox.Show(_parentForm.Name) // in Form1 will show the name of Form2
or you can just have a string which you set the this.Name when you instantiate Form1 in Form2's constructor
class Form1 : Form
{
private string _parentFormName;
public Form1(string name)
{
_parentForm = f;
}
}
Form1 fm = new Form1(this.Name) // in the constructor of Form2;
and then you can directly call that variable like this
MessageBox.Show(_parentFormName);
I am trying to return some data from Form2 to Form1, everything seems fine, I got the data and so, but, when I try to pass my data to a textbox, it doesn't changes the text. Only if I open a new instance of Form1, on Form2 it works. Why this happen? Can't I send the text to the old instance?
I'm using this code;
Form1 (Main Form)
public void updateText(string data)
{
MessageBox.Show(data);
txtGood.Text = data;
}
Form2 SecondaryForm = new Form2();
SecondaryForm.ShowDialog();
Form2 (Second Form with user data)
Form1 MainForm = new Form1();
MainForm.updateText(data);
MainForm.ShowDialog();
this.Close();
So, my question is, how can I pass the data values to the old instance of the main form? without having to create a new instance and show a new instance. Is there a way to do this?
This is because you're creating a instance of Form1 in your Form2 code. What you want to do is setup Form2's parentForm to be the instance of the Form1 that created it.
public partial class Form1 : Form
{
public void CreateForm2()
{
Form2 form2 = new Form2(this);
form2.ShowDialog();
}
public string MyTextboxText
{
get { return txtMyTextbox.Text; }
set { txtMyTextbox.Text = value; }
}
}
public partial class Form2 : Form
{
private Form1 parentForm;
public Form2(Form1 parentForm)
{
this.parentForm = parentForm;
}
public void myButtonClick()
{
parentForm.MyTextboxText = "Hello";
}
}
This code is just an example, probably wont compile as-is.
What you can do is pass the reference of MainForm(Form1) to second Form(Form2). Then instead of creating MainForm again use the reference to update the textbox.
//pass reference to form2
Form2 SecondaryForm = new Form2(mainForm);
SecondaryForm.ShowDialog();
//in the constructor of Form2 save the reference of Form1
Form1 form1 = null
Form2(Form1 mainForm)
{
form1 = mainForm;
}
//then instead of creating a new MainForm again just use reference of Form1
form1.updateText(data);
this.Close()
main form:
private void Button2_Click(object sender, EventArgs e) {
frmCustomersRecord rec = new frmCustomersRecord(this);
rec.ShowDialog();
rec.GetData();
}
child form:
public partial class frmCustomersRecord : Form
{
public frmCustomersRecord()
{
//blank contructor (Instance of an class)
}
frmCustomerDetails cd;
public frmCustomersRecord(frmCustomerDetails parentForm) : this()
{
this.cd = parentForm;
}
//call the methods using child form object
}
Let's say I have "Form1" and "Form2", both are forms.
In Form1 there are the Main Class and the Main method.
In Form1 I create an object like:
public myobject ob1 = new myobject();
But then, in Form2, I have this code:
private void bdCancelar_Click(object sender, EventArgs e)
{
ob1.status = 1; // I can't access ob1 !!!
}
Any help ?
Thanks.
You need an instance of Form1. Normally if you have displayed this form you have instantiated it (Form1 form1 = new Form1()). Then you could operate on this instance and access public members:
form1.ob1.status = 1;
Another possibility is to have your Form2 constructor take a Form1 instance:
public class Form2: Form
{
private readonly Form1 _form1;
public Form2(Form1 form1)
{
_form1 = form1;
}
private void bdCancelar_Click(object sender, EventArgs e)
{
_form1.ob1.status = 1;
}
}
and then when you are somewhere inside Form1 and want to create and show Form2:
var form2 = new Form2(this);
form2.ShowDialog();
I have two forms. First, Form1 has a group box, some labels and a listbox. I press a button and new Form2 is opened and contains some text. I want to transfer the text in Form2 to the listbox in the Form1.
So far, what I have done is make modifier of listbox to public and then put this code in the button of Form2
Form1 frm = new Form1();
frm.ListBox.items.Add(textBox.Text);
But amazingly, this does not add any value. I thought I was mistaken with the insertion so I made the same procedure. This time, I made a label public and added textbox value to its Text property but it failed.
Any ideas?
Try adding a parameter to the constructor of the second form (in your example, Form1) and passing the value that way. Once InitializeComponent() is called you can then add the parameter to the listbox as a choice.
public Form1(String customItem)
{
InitializeComponent();
this.myListBox.Items.Add(customItem);
}
// In the original form's code:
Form1 frm = new Form1(this.textBox.Text);
Let's assume Form1 calls Form2. Please look at the code:
Form1:
public partial class Form1 : Form
{
public Form1()
{
InitializeComponent();
}
private void button1_Click(object sender, EventArgs e)
{
Form2 frm = new Form2();
frm.Show();
frm.VisibleChanged += formVisibleChanged;
}
private void formVisibleChanged(object sender, EventArgs e)
{
Form2 frm = (Form2)sender;
if (!frm.Visible)
{
this.listBox1.Items.Add(frm.ReturnText);
frm.Dispose();
}
}
}
Form2:
public partial class Form2 : Form
{
public string ReturnText { get; set; }
public Form2()
{
InitializeComponent();
}
private void button1_Click(object sender, EventArgs e)
{
this.ReturnText = this.textBox1.Text;
this.Visible = false;
}
}
The answer is to declare public property on Form2 and when form gets hidden. Access the same instance and retrieve the value.
Below code working perfect on my machine.
private void button1_Click(object sender, EventArgs e)
{
Form1 f1 = new Form1();
f1.listBox1.Items.Add(textBox1.Text );//ListBox1 : Modifier property made public
f1.ShowDialog();
}
Ok, If you are Calling Sequence is like, Form1->Form2 and Form2 updates the value of Form1 then you have to use ParentForm() or Delegate to update the previous form.
Form1 frm = new Form1();
frm is now a new instance of class Form1.
frm does not refer to the original instance of Form1 that was displayed to the user.
One solution is, when creating the instance of Form2, pass it a reference to your current instance of Form1.
Please avoid the concept of making any public members like you said
>>i have done is make modifier of listbox to public and then in form2 in button code<<
this is not a good practice,on the other hand the good one is in Brad Christie's Post,I hope you got it.
This code will be inside the form containing myListBox probably inside a button click handler.
Form2 frm2 = new Form2();
frm2.ShowDialog();
this.myListBox.Items.Add(frm2.myTextBox.Text);
frm2.Dispose();