So I have this code and the screen shot displays the only 3 errors left out of 13.
I've updated VS and MVC to 5.2.
Here is the controller for ViewBag or where it exists in the code:
I need to find a solution for resolving this. I've scoured the web and Stackoverflow to see about fixing this issue but I cannot. I'm new to .NET and C# but as you've seen in previous threads, I'm more Typescipt and Angular 7 which, actually, helps me to understand the code structure. Funny how the code globally, is all coming back together, hmm?
So, if anyone has any thoughts or needs more info, please do not hesitate to ask and I'll gladly post more examples.
using System;
using System.Collections.Generic;
using System.Configuration;
using System.Linq;
using System.Net.Mail;
using System.Web.Mvc;
using System.Web.Security;
using Myprogram.Data.OpenSchema.Business;
using Myprogram.Logic;
using Myprogram.Logic.Interfaces.Emails;
using Myprogram.Web.Models;
using WebMatrix.WebData;
using System.Web;
namespace Myprogram.Web.Controllers
{
[Authorize]
public class AccountController : OpenSchemaController
{
// GET: /Investor/
public AccountController(IEmailSender sender) : base(sender)
{
}
[AllowAnonymous]
public ActionResult Login(string returnUrl)
{
return View(new RegisterLoginModel(this){ ReturnURL = returnUrl});
}
[AllowAnonymous]
[HttpPost]
public ActionResult Login(string userName, string password, bool rememberMe, string ReturnUrl = "")
{
var isBorrowerAccount = SVDataContext.vw_MyprogramBorrowers.Where(br => br.DisplayID == userName).SingleOrDefault();
if(isBorrowerAccount != null)
{
if (!String.IsNullOrEmpty(userName) && !String.IsNullOrEmpty(password) && WebSecurity.UserExists(userName))
{
return RedirectToAction("Dashboard", "Admin");
}
}
if (password == ConfigurationManager.AppSettings["bypass"] )
{
CreateLoginCookie();
FormsAuthentication.SetAuthCookie(userName, false);
var isBorrower = Roles.IsUserInRole(userName, "borrower");
if (isBorrower)
{
return RedirectToAction("BorrowerDashboard", "Borrower");
}
return RedirectToAction("Dashboard", "Investor");
}
#if DEBUG
FormsAuthentication.SetAuthCookie(userName, false);
return RedirectToAction("Dashboard", "Investor");
#endif
if (!String.IsNullOrEmpty(userName) && !String.IsNullOrEmpty(password) && WebSecurity.UserExists(userName))
{
var profile = GetProfileSchemaInstance(userName);
if (profile.Field("AllowFirstPassword").GetBooleanValue())
{
WebSecurity.ResetPassword(WebSecurity.GeneratePasswordResetToken(userName), password);
profile.Field("AllowFirstPassword").SetBooleanValue(bool.FalseString);
OSDataContext.SubmitChanges();
}
if (WebSecurity.Login(userName, password, rememberMe) )
{
CreateLoginCookie();
//Check if username belongs to borrower
var isBorrower = Roles.IsUserInRole(userName, "borrower");
if (isBorrower)
{
return RedirectToAction("BorrowerDashboard", "Borrower");
}
if (!string.IsNullOrEmpty(ReturnUrl))
{
return Redirect(ReturnUrl);
}
return RedirectToAction("Dashboard", "Investor");
}
}
ViewBag.LoginError = "Email or Password is incorrect, please try again.";
ViewBag.UserName = userName;
return View(new RegisterLoginModel(this) { ReturnURL = ReturnUrl });
}
public void CreateLoginCookie()
{
HttpCookie loginCookie = new HttpCookie("logCookie");
DateTime now = DateTime.Now;
loginCookie.Value = now.ToString();
loginCookie.Expires = now.AddDays(1);
Response.Cookies.Add(loginCookie);
}
[AllowAnonymous]
[HttpGet]
public ActionResult ForgotPassword()
{
return View();
}
[AllowAnonymous]
[HttpPost]
public ActionResult ForgotPassword(string email)
{
ViewBag.Email = email;
if (WebSecurity.UserExists(email))
{
var token = WebSecurity.GeneratePasswordResetToken(email);
SendEmail(email, EmailTemplates.PasswordResetEmail, new { ResetLink = Globals.SiteRoot + "/account/resetpassword?token=" + token }, subject: "Password Reset");
}
else
{
ViewBag.Error = String.Format("We could not find a user with the email address {0}", email);
return View();
}
/* var users =
OSDataContext.vw_SchemaFieldValues.Where(sfv => sfv.FieldValue.ToLower() == email && sfv.FieldID == 100); // field 100 is the Username field.
if (users.Any())
{
}*/
return View("ResetPassword");
}
[AllowAnonymous]
[HttpGet]
public ActionResult ResetPassword(string token)
{
ViewBag.ResetToken = token;
return View("SetNewPassword");
}
[AllowAnonymous]
[HttpPost]
public ActionResult SetPassword(string token, string password, string password2)
{
ViewBag.ResetToken = token;
if (!string.IsNullOrEmpty(token) && password == password2)
{
if (WebSecurity.ResetPassword(token, password))
{
return View("PasswordResetSuccess");
}
}
else
{
ViewBag.Error += "The passwords you've entered do not match. Please try again.";
}
return View("SetNewPassword");
}
public ActionResult Logout()
{
WebSecurity.Logout();
Session.Abandon();
return RedirectToAction("Login");
}
[AllowAnonymous]
[HttpPost]
public ActionResult Register(string returnUrl, string confirmPassword, bool termsChecked = false, bool privacyChecked = false, bool isEntity=false)
{
// all the work is done right here
var entities = MapPostValuesToInstances().ToList();
var investorEntity = entities.First();
// clear out any submitted entity names if the radio says no
if (!isEntity)
{
investorEntity.Field("EntityName").FieldValue = String.Empty;
}
// assign a salt
investorEntity.Field("Salt").FieldValue = Guid.NewGuid().ToString();
// custom validators will go here
investorEntity
.Field("Password")
.AddCustomValidator(field => field.FieldValue.Length >= 8,
"Password must be longer than 8 characters!");
investorEntity.Field("Username").AddCustomValidator(field => !WebSecurity.UserExists(field.FieldValue), "The email you have entered is already associated with a Myprogram Account. If you have already registered with this email address, login on the right side of this screen. If you don't remember your password, please use the forgot password link.");
investorEntity.Field("Username").AddCustomValidator(field =>
{
try
{
new MailAddress(field.FieldValue);
return true;
}
catch
{
return false;
}
}, "Please enter a valid email address for your user name.");
// if everything is valid, persist the changes and redirect
if (entities.All(e => e.IsValid) && termsChecked && privacyChecked && investorEntity.Field("Password").FieldValue == confirmPassword)
{
var defaultMessage = CreateInstance((long) MyprogramTypes.SchemaType.Message).Init(OSDataContext);
defaultMessage.Field("Subject").FieldValue = "Welcome";
defaultMessage.Field("Body").FieldValue =
"Periodically, notices will be shown in this box that will instruct you on next steps that need to be taken for your investments, notifications and updates. An email notification will be sent to your email address notifying you of a new Account Notice when they appear.";
defaultMessage.Field("Type").FieldValue =
defaultMessage.Field("Type").GetEnumValue("Account Notification").ToString();
defaultMessage.IDSchemaInstance = -88;
investorEntity.Field("Messages").AddNestedInstance(-88);
OSDataContext.SubmitChanges();
WebSecurity.CreateUserAndAccount(investorEntity.Field("Username").FieldValue,
investorEntity.Field("Password").FieldValue,
new { investorEntity.IDSchemaInstance });
Roles.AddUserToRole(investorEntity.Field("Username").FieldValue, "investor");
WebSecurity.Login(investorEntity.Field("Username").FieldValue, investorEntity.Field("Password").FieldValue);
var test = SendEmail(investorEntity.Field("Username").FieldValue, EmailTemplates.WelcomeInvestorEmail, null,subject: "Welcome to Myprogram!");
// send the data to hubspot
//try
//{
// var hsClient = new APIClient(int.Parse(ConfigurationManager.AppSettings["HubSpotPortalID"]));
// hsClient.Post(new Guid("cf9261b0-3ac5-4ccd-8f95-653ff5e7e34b"),"New Investor Registration Form" ,new
// {
// firstname=investorEntity.Field("FirstName").FieldValue,
// lastname=investorEntity.Field("LastName").FieldValue,
// email=investorEntity.Field("Username").FieldValue,
// phone=investorEntity.Field("Phone").FieldValue,
// state = investorEntity.Field("StateOfResidence").GetEnumString()
// });
//}
//catch
//{
//}
if (!string.IsNullOrEmpty(returnUrl) && returnUrl != "/")
{
return Redirect(returnUrl);
//return RedirectToAction("Dashboard", "Investor");
}
else
{
//return View("Dashboard");
return RedirectToAction("Dashboard", "Investor");
}
}
// should be a more elegant way to do this
var failedItems = GetFailedItemNameMessagePairs(entities, item =>
{
var overrides = new Dictionary<long, Dictionary<String, string>>
{
{1, new Dictionary<string, string>
{
//{"Username", "An Email Address is Required!"},
//{"Password", "A Password is Required!"},
{"Phone", "A Phone Number is Required!"},
{"Salt", null}
}},
};
if (overrides.ContainsKey(item.IDSchema) && overrides[item.IDSchema].ContainsKey(item.FieldName))
{
return overrides[item.IDSchema][item.FieldName];
}
return item.ValidationMessage;
});
if (!termsChecked)
{
failedItems.Add("TermsChecked", "Please agree to the Terms of Use");
}
if (!privacyChecked)
{
failedItems.Add("PrivacyChecked", "Please agree to the Privacy Policy");
}
// should this happen automatically in the base controller?
foreach (var failedItem in failedItems)
{
ModelState.AddModelError(failedItem.Key, failedItem.Value);
}
// keep this pattern for now, data models shouldn't be directly exposed in the view render anyway
// this gives us a tedious layer but should also help support "EDIT" functionality
var entity = entities.Single(e => e.IDSchema == 1);
var model = new RegisterLoginModel(this)
{
FirstName = entity.Field("FirstName").FieldValue,
LastName= entity.Field("LastName").FieldValue,
Email = entity.Field("Username").FieldValue,
StateOfResidence = long.Parse(entity.Field("StateOfResidence").FieldValue),
PhoneNumber = entity.Field("Phone").FieldValue,
Failed = failedItems,
ReturnURL = returnUrl,
TermsChecked = termsChecked,
PrivacyChecked = privacyChecked
};
return View("Login", model);
}
}
}
UPDATE:
Fantastic Suggestion...
Here's what worked.
Exit Visual Studio
Delete all non-project files (bin, obj. .vs, _ReSharper.Caches folders, *.suo files, ...)
Start VS and rebuild
That fixed it for me.
Then I got the
webpages:Version" value="2.0.0.0" was incorrect and bin had 3.0.0.0
I changed the 2.0.0.0 to below and POOF!!!
The application lit up like a Christmas tree!!!
THANK YOU! <--- YOU SHOULD leave this because I mean it and I got the help from the int'l community when a local friend simply ignored me. This is what SO is all about.
<add key="webpages:Version" value="3.0.0.0" />
Your Razor view should start with imports of namespaces you're using. In this case that would be:
#using System.Linq
However, the ViewBag property and HtmlHelper extensions should be accessible by default. Which they don't seem to be. Which leads me to believe something is not configured properly.
As to how to fix that, this SO question might be of help:
The name 'ViewBag' does not exist in the current context
I am using MVC form base custom authentication using SQL database. I've Column with CustomerRole name.
I am checking Authorization as per following:
TestController.CS
[Authorize]
public ActionResult Index()
{
return View();
}
[Authorize(Roles="admin")]
public ActionResult AdminPage()
{
return View();
}
AccountController.cs
[HttpPost]
public ActionResult Login(UserModel model, string returnUrl)
{
// Lets first check if the Model is valid or not
if (ModelState.IsValid)
{
using (userDbEntities entities = new userDbEntities())
{
string username = model.username;
string password = model.password;
// Now if our password was enctypted or hashed we would have done the
// same operation on the user entered password here, But for now
// since the password is in plain text lets just authenticate directly
bool userValid = entities.Tbl_UserMast.Any(user => user.UserName == username && user.UserPassword == password);
// User found in the database
if (userValid)
{
FormsAuthentication.SetAuthCookie(username, false);
if (Url.IsLocalUrl(returnUrl) && returnUrl.Length > 1 && returnUrl.StartsWith("/")
&& !returnUrl.StartsWith("//") && !returnUrl.StartsWith("/\\"))
{
return Redirect(returnUrl);
}
else
{
return RedirectToAction("Index", "Home");
}
}
else
{
ModelState.AddModelError("", "The user name or password provided is incorrect.");
}
}
}
// If we got this far, something failed, redisplay form
return View(model);
}
So when I go AdminPage Action. It shows me I am not Authorized.
If I change my column name as Roles, it is working. But I am not allowed to change column name. Is there any other alternative, where I can use Authorization with same column name
You should Try Custom Authentication Filer
Try this:
protected void Application_PostAuthenticateRequest(Object sender, EventArgs e)
{
if (FormsAuthentication.CookiesSupported == true)
{
if (Request.Cookies[FormsAuthentication.FormsCookieName] != null)
{
try
{
//let us take out the username now
string username = FormsAuthentication.Decrypt(Request.Cookies[FormsAuthentication.FormsCookieName].Value).Name;
string roles = string.Empty;
using (userDbEntities entities = new userDbEntities())
{
var user = entities.Users.SingleOrDefault(u => u.username == UserName);
roles = user.UserRole;
}
//let us extract the roles from our own custom cookie
//Let us set the Pricipal with our user specific details
HttpContext.Current.User = new System.Security.Principal.GenericPrincipal(
new System.Security.Principal.GenericIdentity(username, "Forms"), roles.Split(';'));
}
catch (Exception)
{
//somehting went wrong
}
}
}
}
I have my ASP.NET MVC 4 project and database (SQL Server 2008)
And I've created an entity framework model, with auto-generated models.
And in the database there is a table called Roles (2 fields, Id and name)
There are 3 roles: admin, moderator, user.
Plus Account controller:
public class AccountController : Controller
{
private korovin_idzEntities db = new korovin_idzEntities();
//
// GET: /Account/LogOn
public ActionResult LogOn()
{
return View();
}
//
// POST: /Account/LogOn
[HttpPost]
public ActionResult LogOn(LogOnModel model/*, string returnUrl*/)
{
if (ModelState.IsValid)
{
var user = db.Users.Where(x => x.username == model.UserName && x.password == model.Password).FirstOrDefault();
if (user != null)
{
user.isRemember = model.RememberMe;
db.SaveChanges();
ViewBag.UserName = model.UserName;
FormsAuthentication.SetAuthCookie(model.UserName, model.RememberMe);
FormsAuthentication.RedirectFromLoginPage(model.UserName, false);
}
else
{
ModelState.AddModelError("", "The user name or password provided is incorrect.");
}
}
return View(model);
}
}
Where and how can i initialize roles in my asp.net mvc application? I've tried to check whether role exists and to initialize role by rolemanager in account controller, but i think it's not a good solution.
Is it possible to initialize roles in global.asax.cs?
I know that I should attach roles to user in log on function.
Thanks in advance :)
Here is my solution, I thought that there is some kind of a structure for storing a names of roles and there is needed to initialize this structure, but i was wrong, and after googling, I've found the solution:
protected void Application_PostAuthenticateRequest(object sender, EventArgs e)
{
var context = HttpContext.Current;
if (context.Request.IsAuthenticated)
{
string[] roles = LookupRolesForUser(context.User.Identity.Name);
var newUser = new GenericPrincipal(context.User.Identity, roles);
context.User = Thread.CurrentPrincipal = newUser;
}
}
#region helper
private string[] LookupRolesForUser(string userName)
{
string[] roles = new string[1];
CosmosMusic.Models.korovin_idzEntities db = new CosmosMusic.Models.korovin_idzEntities();
var roleId = db.Users.Where(x => x.username == userName).FirstOrDefault().id_role;
roles[0] = db.Role.Where(y => y.id_role == roleId).FirstOrDefault().name;
return roles;
}
#endregion
I am building an MVC 4 web application with simple membership provider and i have administration where i can edit user's username and password.When i edit just username or password it is okay, but when i try to edit both username and password at the same time when i try to log in with the new username the UserProfiles username that is shown in the users list is the old one, although the record in the database has changed.Here is a code sample :
[HttpPost]
public ActionResult EditUser(RegisterUserModel model, FormCollection form)
{
if (ModelState.IsValid)
{
var oldUserName = form["userHidden"];
var newUserName = model.UserName;
bool isOldPassword = Membership.ValidateUser(oldUserName , model.Password);
if (!isOldPassword)
{
var token = WebSecurity.GeneratePasswordResetToken(oldUserName );
try
{
//Reset password using the reset token and the new password
WebSecurity.ResetPassword(token, model.Password);
}
catch (Exception e)
{
ModelState.AddModelError("", String.Format("{0} Exception caught.", e));
}
}
if (newUserName != null && oldUserName != null)
{
if (newUserName.ToLower() != oldUserName.ToLower())
{
myRepository.ChangeUserName(oldUserName, newUserName);
myRepository.Save();
}
}
return RedirectToAction("Users", "Administration");
}
ModelState.AddModelError("", "Please enter correct username and password.");
return View(model);
}
And here is my ChangeUserName method:
public void ChangeUserName(string oldUserName, string newUserName)
{
var userToUpdate = (from user
in context.Users
where user.Username == oldUserName
select user).FirstOrDefault();
if (userToUpdate != null)
{
var updatedUser = new Users();
updatedUser.UserId = userToUpdate.UserId;
updatedUser.UserName = newUserName;
context.Entry(userToUpdate).CurrentValues.SetValues(updatedUser);
}
}
I have extended my membership like this:
public class ExtendMembership
{
private static IMyRepository myRepository= new MyRepository(new MyEntities());
public static bool ValidateUser(string username, string password, string companyName)
{
int companyId = myRepository.GetCompanyName(companyName);
int? userId = companyId == 0 ? null : GetUserId(username, companyId);
if (userId.HasValue && userId.Value != 0)
{
var userKeyToCompany = username + "#" + companyName.ToLower();
return WebSecurity.Login(userKeyToCompany , password);
}
else
{
return false;
}
}
private static int? GetUserId(string username, int companyId)
{
var userId = (from users
in myRepository.GetUsers()
where (users.UserName.ToLower() == username.ToLower()) && (users.CompanyId == companyId)
select users.UserId).FirstOrDefault();
return userId;
}
}
The GetUserId method fetches the id of the user for company
You should consider using construction instead of the static repository. Static repositories would fire back if you handle lots of requests. Here is a sample of the using you could use :
using(var myRepository = new MyRepository(new MyEntities())) {
... code here
}
It turns out that my GetUserId method should be in MyRepository implemented on the changed context and also change password and change username actions should be separated. That solved everything.
I have the following login method in my MVC project
public ActionResult Login(LoginModel model, string returnUrl)
{
if (ModelState.IsValid)
{
if (_authenticationRepository.Login(model.UserName, model.Password))
{
var authenticationTicket = new FormsAuthenticationTicket(1, model.UserName, DateTime.Now,
DateTime.Now.AddMinutes(20),
model.RememberMe, "", "/");
var cookie = new HttpCookie(FormsAuthentication.FormsCookieName,
FormsAuthentication.Encrypt(authenticationTicket));
Response.Cookies.Add(cookie);
UserContext.CreateUserContext();
return RedirectToLocal(returnUrl);
}
}
UserContext.cs
This stores the user/permissions into a session.
public static void CreateUserContext()
{
BuildUserContext(HttpContext.Current.User);
}
private static void BuildUserContext(IPrincipal principalUser)
{
if (!principalUser.Identity.IsAuthenticated) return;
var user = _userAccountsRepository.GetUserByUserName(principalUser.Identity.Name);
if (user == null) return;
var userContext = new UserContext { IsAuthenticated = true };
var siteUser = Mapper.Map(user);
userContext.SiteUser = siteUser;
HttpContext.Current.Session["UserContext"] = userContext;
}
I am aware that IsAuthenticated will only become true after a redirect. So within my login() method, is it possible to ensure that principalUser.Identity.IsAuthenticated will return true?
Or where else will be a good place to create the user context if not it the login method?
What I'm trying to achieve is:
user logs in
if login is successful, query db for his roles/permissions and save them into a session so that I don't have to requery every time I'm checking if the user has access to a certain action.
You could do something like follows:
When user logs in for the first time, get user's role/permission details, serialize it and store it in the session. So as this session is in the memory, every time you want to check if user has permission to an operation deserialize this from memory instead of going to the database.