I want to create the equivalent of a wait for element present command with custom timeout time
public static void WaitForElementPresent(string Xpath, int WaitTime, int OriginalWaitTime)
{
try
{
SeleniumBrowser.driver.Manage().Timeouts().ImplicitlyWait(TimeSpan.FromSeconds(WaitTime));
SeleniumBrowser.driver.FindElements(By.XPath(Xpath));
SeleniumBrowser.driver.Manage().Timeouts().ImplicitlyWait(TimeSpan.FromSeconds(OriginalWaitTime));
}
catch (Exception)
{
throw new Exception("Could not find the" + Xpath + "Xpath after" + DefaultWaitTime + "second");
}
}
So far my code looks like this however instead of setting a hard coded integer at the end id rather get the previous timeout time registered as an integer mid test from some obscure function and call it so to reset the timeout to its previous time.
You should avoid those Implicit time outs as much as possible and stick to explicit waiting. Explicit waiting is not Thread.Sleep(time) but explicitly waiting for your element.
A huge lesson came in realizing how Implicit and Explicit waiting work. One thing to note is that C# will look for the Element immediately and when it is not found will crash with a "No Such Element" exception. If you mix implicit and explicit waiting together you will be stuck waiting until the Implicit wait time completes even if the element has been found. Not good and caused huge time issues for tests.
I would not recommend using XPath unless needed, however, you should use one of the following ways to wait. This is mostly handled with Selenium code already.
I personally extended Selenium to do the following call with set Page Objects
Expected Condition way:
public static void WaitForElement(this IWebElement element, IWebDriver
driver, int waitTime)
{
try{
var wait = new WebDriverWait(driver, timeSpan.FromSeconds(waitTime));
wait.Until(ExpectedConditions.ElementToBeClickable(element));
Logging.Information(elementText + " is clickable");
}
catch (NoSuchElementException)
{
throw new Exception("Could not find the" + Xpath + "Xpath after" + DefaultWaitTime + "second");
}
}
}
This would look like this with a mapped page object:
SaveButton.WaitForElement(driver);
I also extended selenium to use the same waiting for unmapped Page Objects.
You could do something similar with Extending the Driver class as well to match what you are currently doing.
public static void WaitForLocator(this IWebDriver driver, By by, int waitTime)
{
Logging.Action("Using locator: " + by + " to find element");
var wait = new WebDriverWait(driver, TimeSpan.FromSeconds(waitTime));
wait.Until(ExpectedConditions.ElementToBeClickable(by)); //There are several Expected conditions
Logging.Information("Found element with locator: " + by);
}
This would look like this with your current example
driver.WaitForLocator(By.XPath('your XPath');
This method will also allow you to use CSS selectors, Ids, etc by changing your By type.
The other way to explicitly wait for elements is using
var wait = new WebDriverWait(driver, TimeSpan.FromSeconds(30));
var saveButton = wait.Until(x => driver.FindElements(By.XPath(Xpath));
Not sure you if meant to use driver.FindElements or driver.FindElement since the name of the method is WaitForElementPresent but you used driver.FindElements. Find elements returns a list of elements not just the element you were looking for.
Hope this helps.
Related
I'm doing unit testing on a system using Selenium with a Page Object Model.
Usually I'm able to figure out a solution to such a problem in relatively short order, but this one is being rather tenacious, so I thought I should just get clarification on the root of the problem rather than write another workaround.
There is some PageObject class that has an IWebElement property with the necessary FindsBy attribute for locating a element on the page, and a method that uses said property:
public class Foo : BasePage
{
...
[FindsBy(How = How.XPath, Using = "//a[#title='Edit']")]
protected IWebElement LinkEdit { get; set; }
...
public Bar ClickEdit()
{
WaitUntilInteractable(LinkEdit);
LinkEdit.Click();
return new Bar(driver);
}
...
}
Note that this is the only reference to LinkEdit
For clarity, WaitUntilInteractable is defined in BasePage as:
protected void WaitUntilInteractable(IWebElement webElement)
{
var wait = new WebDriverWait(driver, TimeSpan.FromSeconds(30));
_ = wait.Until(SeleniumExtras.WaitHelpers.ExpectedConditions.ElementToBeClickable(webElement));
}
My understanding of how the PageFactory works with Selenium is that whenever you reference a IWebElement property of a class, the IWebDriver will then find the element within the page.
This much is said on this page: https://github.com/seleniumhq/selenium/wiki/pagefactory
... every time we call a method on the WebElement, the driver will go and find it on the current page again.
Given that knowledge, I don't quite understand how I can run into StaleElementReferenceException when simply referencing one of these properties. Surely either the element cannot be found, in which case a NoSuchElementException will be thrown, or it can be found, in which case it is present on the document, and not "stale".
Perhaps I've misunderstood staleness.
A StaleElementException occurs when the element being reference is no longer attached to the HTML document. This can happen in amazingly small amounts of time, and generally occurs when JavaScript is updating the page. As a further frustration, the WebDriverWait object does not catch StaleElementException's and continue waiting. You must tell WebDriverWait to ignore these exceptions:
protected void WaitUntilInteractable(IWebElement webElement)
{
var wait = new WebDriverWait(driver, TimeSpan.FromSeconds(30));
wait.IgnoreExceptionTypes(typeof(StaleElementException));
wait.Until(SeleniumExtras.WaitHelpers.ExpectedConditions.ElementToBeClickable(webElement));
}
Now when webElement is stale, it retries the operation until the wait object times out.
the html
<span id="banner">Rolling in 10.00...</span>
my code
public void waitroller()
{
Console.WriteLine("waiting roller");
WebDriverWait wait = new WebDriverWait(PropertiesCollection.driver, TimeSpan.FromDays(2));
wait.Until<IWebElement>((d) =>
{
IWebElement element = PropertiesCollection.driver.FindElement(By.Id("banner"));
if (element.Text == "Rolling in 20.00...")
{
return element;
}
return null;
});
}
OR
public void waitroller()
{
new WebDriverWait(PropertiesCollection.driver, TimeSpan.FromMinutes(1.5)).Until(ExpectedConditions.TextToBePresentInElementLocated(By.Id("banner") , "Rolling in 20.00..."));
}
I'm stuck with this innertext because the innertext in the html is always changing and i want to make a webdriverwait that waits until the innertext in the span banner is "Rolling in 20.00" . Is there any way to make custom expected conditions because I am not understand custom expected condition.
what i need is something like this
new WebDriverWait(PropertiesCollection.driver, TimeSpan.FromMinutes(1.5)).Until(ExpectedConditions.TextToBePresentInElement(PropertiesCollection.driver.FindElement(By.Id("banner"), "Rolling in 20.00...");
but this is not work because i think the id="banner" is innerText
there is one way that work but can't work for long because i think it is the wrong way of doing it . i loop the element banner many times and check if the innerText is equals to "Rolling in 20.00..." but have error also
public void waitroller()
{
Console.WriteLine("waiting roller");
WebDriverWait wait = new WebDriverWait(PropertiesCollection.driver, TimeSpan.FromDays(2));
IWebElement bannerElement = PropertiesCollection.driver.FindElement(By.Id("banner"));
wait.Until((d) =>{ return bannerElement.Text.Contains("Rolling in 20.00"); });
}
I don't know what you mean by "innertext", but with Selenium's WebDriverWait you can wait for whatever you want. You don't have to use the ExpectedConditions, they're only for programmers' comfort.
Example:
new WebDriverWait(...).Until(driver => driver.FindElement(...).Text.Equals(...));
On the other hand, your problem might be a completely different one. Is your "roller" a countdown where the text changes very fast? In this case you might never reach the expected condition. I think Selenium checks the expected conditions every 500 milliseconds, so it doesn't even notice when "Rolling in 20.00" is displayed for just let's say 50 millisecods and then has already changed to "Rolling in 19.95" when Selenium checks for the next time.
I'm using Selenium Webdriver with C# and I'm wondering if there's a way to override the FindElement method? What I'd like to do - if possible - is to add an extra parameter and code to the method that would force it to wait for the element to be visible before proceeding.
For example, it would then be something like this:
Driver.FindElement(By.Id("orion.dialog.box.ok"), 60).Click();
This would wait up to 60 seconds for the element to appear and be available to click.
Any ideas how to do this?
Thanks,
John
You could use ImplicitWait for this. You can create a new user defined function to accept the By object and the timeout seconds and have the function return the IWebElement, something like below:
IWebElement elem = MyOwnGetElement(By.id("test"),60);
The above function might have the below code, where time_out_sec is the function parameter.
WebDriver driver = new FirefoxDriver();
driver.Manage().Timeouts().ImplicitlyWait(TimeSpan.FromSeconds(time_out_sec));
driver.Url = "http://somedomain/url_that_delays_loading";
IWebElement myDynamicElement = driver.FindElement(By.Id("someDynamicElement"));
I would suggest you add it as an extension method. Pseudo code:
public static IWebElement WaitForAndFindElement(this IWebDriver driver, By by)
{
// do a wait
// something like...
WebDriverWait wait = new WebDriverWait(TimeSpan.FromSeconds(60)); // hard code it here if you want to avoid each calling method passing in a value
return wait.Until(webDriver =>
{
if (webDriver.FindElement(by).Displayed)
{
return webDriver.FindElement(by);
}
return null; // returning null with force the wait class to iterate around again.
});
}
Just to state, an implicit wait is going to be part one of your solution. It will cause Selenium to wait up to 60 seconds for an element to be present in DOM but being visible is something entirely different.
.Displayed will handle that, and it must be handled within a WebDriverWait.
I am coding with Selenium for 6+ months and I had the same problem as yours. I have created this extension method and it works for me every time.
What the code does is:
During 20 seconds, it checks each 500ms, whether or not the element is present on the page. If after 20 seconds, it's not found, it will throw an exception.
This will help you make a dynamic wait.
public static class SeleniumExtensionMethods {
public static WebDriverWait wait = new WebDriverWait(driver, TimeSpan.FromSeconds(20));
public static void SafeClick(this IWebElement webElement) {
try {
wait.Until(ExpectedConditions.ElementToBeClickable(webElement)).Click();
} catch (TargetInvocationException ex) {
Console.WriteLine(ex.InnerException);
}
}
and then use it like this:
IWebElement x = driver.FindElement(By.Id("username"));
x.SafeClick();
I am looking for a way to check that the page was loaded using Selenium. So basically does the url point to a correct address (in chrome the browser shows something like this) :
I am using the following code:
var driver = new FirefoxDriver();
driver.Url = "SomeUrl";
Currently I am comparing the title to "SomeUrl is not available" and if it matches I mark that the page has failed to load.
But is there a better way?
I would suggest, if you know what control ID/or link or/Class is going to appear on your page. Then wait for that element to appear on screen for a defined period of time.
I that element appears then your next line of code will be executed
Here is the simple version of m method. You can make it more dynamic based on your need.
/// <summary>
/// WaitForElementOnPage() method waits a passed number of seconds for the existence
/// of a passed IWebElement object. If the object is found the method return an IWebElement of the object
/// If the object is not found in the passed number of seconds, the method returns a null IWebElement
/// </summary>
public IWebElement WaitForElementOnPage(string controlID, int waitTime)
{
IWebElement element = null;
IWebElement elementFound = null;
try
{
WebDriverWait wait = new WebDriverWait(Driver, TimeSpan.FromSeconds(waitTime));
Thread.Sleep(3000);
elementFound = wait.Until<IWebElement>((d) =>
{
element = d.FindElement(By.Id(controlID));
break;
return element;
});
}
catch (Exception ex)
{
Log.Error(ex);
elementFound = null;
}
return elementFound ;
}
I personally try to locate body or frameset element on the page.
Based on my experience while using selenium with chromedriver, page content sometimes doesn't show up and I need to run webdriver.refresh() 1-2 times. It doesn't happen all the time, but I run big amount of chrome instances on one machine and this approach was the most effective for now to avoid this.
So I try to locate body or frameset elements and reload few times before I give up.
The advantage of this solution is also the fact that it will also work in case Chrome changes its messages in the future. It will also work with other browsers.
Guys, I have problem with waitForPageToLoad condtion. I'm using C# with Nunit, and I don't know exactly what I should use instead of 'waitForPageToLoad'/'waitForElementPresent'. Maybe someone knows how I can use 'waitForPageToLoad'/'waitForElementPresent' in Selenium 2?
I use FindElement() for something on the new page. Wrap in in a loop that will keep trying until the element is found, with a maximum wait.
// pseudocode WebElement wait_for_element(By locator)
while (!timeout) {
try {
return driver.FindElement(locator);
} catch (Exception) {
Thread.sleep(1000);
}
// check for timeout here
}
throw new NoSuchElementException("Timeout waiting for "+locator);
ISelenium selenium = new DefaultSelenium( "localhost", 4444, "*chrome", "
http://localhost/UrlOfAppToTest/" );
selenium.WaitForPageToLoad( "30000" );
Is that what you're looking for?
You could use a explicit wait method to wait for your action/page to load.
With that you can specify a condition to be met, and when it is met your test will continue.
See link for more details:
Selenium HQ, explicit wait