I have a class that fires an event at a fairly rapid frequency (every 100ms). To avoid slowing down this process, event handlers should hand off the processing to some kind of background task/thread/worker (as opposed to doing it within the event handler).
What's the best approach? Should I use Task.Factory.StartNew within the event handler? Will there be an overhead of creating tasks this rapidly (e.g. 5 event handlers will create 5 tasks every 100ms)? Or could I use a BackgroundWorker (instantiated in a subscriber's constructor), and in the event handler call the .RunAsync method?
Two ways:
Either use Task.Factory.StartNew. This method relies on the ThreadPool to minimize the task creation cost. This should be ok in most cases.
If you need to further reduce the performance impact, you can create a producer/consumer queue. When the event is triggered, enqueue a notification. On the other side, a thread monitors the queue and process the notifications as they arrive.
Related
I have a background worker thread continuously updating the data displayed in a window from a network source. I also have a button which will fire an event.
My question is, at what stage (relative to the background worker execution) is the event method executed? Is it similar to threads in that they happen simultaneously? I.e, will the background worker will still be running whilst my button click method is executing? In which case, I will need to use locking. Or will the background worker pause until the button click method has terminated?
Events raised by UI controls (e.g. buttons) execute in the main thread, a.k.a. the UI thread. Events you raise yourself are raised on whatever thread you raise them on. All event raisings block the execution of their own thread until they complete. They're not very special, when you call them: Just a little syntactic sugar around calling an arbitrary list of delegates.
In the absence of any explicit synchronization code, any other threads humming along the background will merrily continue to execute.
If you need or want to communicate between an event handler in the UI thread and a worker thread, you'll need to write explicit code to do so. Nothing special here: Just two threads.
And if you've got both an event handler and a thread putting their greasy little mitts on the same object, and if the operations on that object are not atomic, you're correct: You'll need locking. Thread-safe collections may come in handy.
To set the stage, I have a custom class called Scheduler that holds multiple Task objects (this is a custom class as well). Each task has a BackgroundWorker object to run long running work. I am currently doing some testing of having many of these tasks executing quickly and being handled at the same time.
In my Task object, I raise an a custom event (TaskCompletedEvent) in the TaskWorkerCompleted handler to alert the scheduler that a task is completed. The scheduler uses the same event handler for every task's TaskCompletedEvent.
What I want to know is if I am currently in the Scheduler TaskCompletedEvent handler executing code and another event finishes up, what happens? Both are going to be on the UI Thread, so does the one currently in the event handler finish up before the other one proceeds? I'm getting confused on what is going to happen when two events finish simultaneously and need to be handled.
No, the events themselves don't know about the UI threads. So the events will be dispatched in the same thread where they are fired (this is most probably in the backgroundworker's thread, right?)
If your both events are fired in the UI thread, this cannot be simultaneous (after all, the UI thread is executing either one or another event firing code), so the second event isd perhaps going to be fired when the first event is finished with firing and dispatching.
If you want the Scheduler to marshal the events to the UI thread, that is a slightly different story. Your code which needs to be executed at the UI thread will be actually posted into a kind of event queue of that thread, and whatever event-firing code happens to be first, gets executed first.
I am working on a Messenger library. The main class has a Login method. When logging in, all contact list data is downloaded and stored until the Login has completed, at which point I raise a UserAdded event for each user that was downloaded.
Currently I raise the events right at the end of the Login method, one by one. This works, but it means if I perform a lengthy operation inside a UserAdded event handler, the library consumer does not get their events in a timely fashion.
One way around this I can see would be to raise each event asynchronously, but this would thrash the threadpool.
Am I doing it the right way currently? Should I simply make a note in the documentation warning against performing lengthy operations inside event handlers?
Perhaps you might want to change your event handler to simply "enqueue" into a threadsafe queue work items. You can then have a single thread which pumps the queue continuously to actually process the messages. That way the raise happens very quickly and there is only one thread actually processing the queue of work items.
However doing this means you now have to deal with the fact that raising your event does not mean it has been immediately processed, which could affect logic you have in your app.
I'm attempting to monitor the status of many HPC jobs running in parallel in a single threaded program, I'm subscribing to events raised by OnJobState and when monitoring as few as three jobs event state changes will go missing and the job is stuck running.
I'm assuming I need a thread per job to catch all the events but I can't find any information about the limits of events subscripton in a single thread program.
I would have thought the .net platform would queue this all up but that doesn't appear to be the case.
Events are synchronous by default. That means that the object that raises an event will continue its execution only after all event handlers finished their work. The event handlers will run on the same thread as the object that raises the event. That leads to the following conclusions:
The .NET framework can't queue anything, because the events are raised one after another
You should not do heavy computing in event handlers. If the events are fired in rapid succession, even moderate computing should be avoided.
If you want queuing, you need to implement it yourself: In your event handler, add the info about the new event to a thread safe queue and process this queue from another thread.
I made this question more general to remove the confusion over HPC, looks like I have no control over how my event hander is executed so I need to make it thread safe.
I have a weird behavior in my GUI code. If the user produces a lot of events in a short time, it happens that a running event handler method gets interrupted by another event handler method.
Since everything runs in the same thread (GUI thread) everything should run sequential and an interruption should not be possible, or do I misunderstand something?
Thanks for your advise,
Eny
No, that doesn't happen. You are right in your understanding that the thread runs sequentially.
The GUI thread can be interrupted but only to run a different thread, it will not re-enter the GUI thread to handle another event. A thread only has one instruction pointer and thus can only be in one place in the code, it can not be interrupted by itself.
If you are experiencing something that look like the GUI thread is re-entered, the reason is something else.
The GUI thead can however "interrupt" itself by calling the Application.DoEvents method.
You are correct, in a single threaded application, event should be run sequentially. There are a few exceptions:
An event is fired and calls the first event handler in its subscriber list. The event handler fires an event of its own, which calls other event handlers. In this case, it would appear that the event was interrupted, but it was not. When the original event handler completes, the next event handler in the list will be called.
An event handler calls the Application.DoEvents() method. This will suspend the current event and process any messages waiting in the message queue (which will usually fire events of their own), and when it has finished processing all messages, it will return to the event. A problem may occur when Application.DoEvents() causes a recursive call to the event which called it, as a result of firing an event from one of the messages it processed.
Event handlers may be executed on different threads. Some events are not fired on the UI thread, and may fire on their own thread. This could cause events to be fired out of order and interrupt each other on a thread contexts switch. Make sure that the events you consume are fired on the UI thread, and if not, Control.Invoke() them onto the UI thread. An example of an event that is fired on a separate thread, possibly without you being aware of it, is the System.Threading.Timer.Elapsed event.