I have a form on which there is a LogOutEvent and a form closing event.
Here is the code,
private void btnLogOut_Click(object sender, EventArgs e)
{
DialogResult yesNo = MessageBox.Show(this, "Are you sure you want to Log Off?", "Log Off", MessageBoxButtons.YesNo, MessageBoxIcon.Question, MessageBoxDefaultButton.Button1);
if (yesNo == DialogResult.Yes)
{
new LoginForm();
this.Close();
string tst2 = Logout(AgentId, AgentPwd, ExtensionId);
if (tst2 == "TCF000")
MessageBox.Show(" Logout Success");
else
MessageBox.Show("Logout Failed");
}
}
And a Form Closing Event
private void MainGUI_FormClosing(Object sender, FormClosingEventArgs e)
{
if (e.CloseReason == CloseReason.UserClosing)
{
DialogResult yesNo = MessageBox.Show(this, "Are you sure you want to Log Off?", "Log Off", MessageBoxButtons.YesNo, MessageBoxIcon.Question, MessageBoxDefaultButton.Button1);
if (yesNo == DialogResult.Yes)
{
Application.Exit();
}
else
{
e.Cancel = true;
}
}
}
My Problem is when i click on the LogOut button its calling the form closing event. Can anybody advice a better code for this?
When i click on close 'X' it should close the application and when i click on LogOut it should close the current window and go to the login form.
I'm sure that there is a better solution, but this does work:
private bool loggingOut;
private void Form1_DoubleClick(object sender, EventArgs e)
{
this.loggingOut = true;
this.Close();
// This is optional as we are closing the form anyway
this.loggingOut = false;
}
private void Form1_FormClosing(object sender, FormClosingEventArgs e)
{
if (e.CloseReason == CloseReason.UserClosing && !loggingOut)
{
// Handle form closing here
}
}
This allows your form closing event handler to identify if another method is invoking the form close, and skip the normal handling if it is.
Alternatively you could just Hide the form instead, and re-use the same form instance the next time the user logs in.
well... yes! the form is closing; why wouldn't it fire the event?
If the CloseReason isn't helping, then just throw a bool field onto the form that you set to true when you click logout; and check that field in the closing event.
Related
Here is my C# code:
private void StudentReg_FormClosing(object sender, FormClosingEventArgs e)
{
DialogResult dialog = MessageBox.Show("Do you really want to close this window?", "Exit", MessageBoxButtons.YesNo);
if (dialog == DialogResult.Yes)
{
Application.Exit();
}
else if (dialog == DialogResult.No)
{
e.Cancel = true;
}
}
Depending on how you setup your application like if this is your main form or you have multiple you may need to just remove the event to avoid duplicate calls to it.
Remove the event handler before calling application.exit and I think your issue will be solved.
This is psuedo-code.
private void StudentReg_FormClosing(object sender, FormClosingEventArgs e)
{
DialogResult dialog = MessageBox.Show("Do you really want to close this window?", "Exit", MessageBoxButtons.YesNo);
if(dialog == DialogResult.Yes)
{
StudentReg.FormClosing -= StudentReg_FormClosing;
Application.Exit();
}
else if(dialog == DialogResult.No)
{
e.Cancel = true;
}
}
I doubt if you really want Application.Exit();: you prompt (bold is mine)
Do you really want to close this window
It is the window (Form), not the entire Aplication you want to close. If it's your case, you can just do nothing and let the form (window) close itself:
private void StudentReg_FormClosing(object sender, FormClosingEventArgs e)
{
// Cancel closing (i.e. do NOT close the form) if and only if user's chosen "No".
// Do nothing (i.e. do not cancel) in other cases (let the form be closed)
// So we assign true (cancel) if "No" has been pressed, false otherwise
e.Cancel = MessageBox.Show(
"Do you really want to close this window?",
"Exit",
MessageBoxButtons.YesNo) == DialogResult.No;
}
I'm writing a WinForm desktop application. In the main form, the user clicks on a button which calls another form for the user to submit data to. At the end of this submission process, the user clicks on a "Save" menu item to close the subform.
This is the code for the subform calling:
private void btnSubmit_Click(object sender, EventArgs e)
{
// code for setting myFormArgs
myForm form = new myForm(myFormArgs);
form.ShowDialog();
// the user clicked "Yes" on a "Confirm" MessageBox
if (form.DialogResult == DialogResult.Yes)
{
// code for saving data
form.Dispose();
}
}
and this is the code for the "Save" menu item in the subform:
private void menuSave_Click(object sender, EventArgs e)
{
string message, title;
MessageBoxIcon icon;
MessageBoxButtons buttons;
if(DataSubmitted)
{
if(ValidData)
{
message = "Confirm?";
title = "Select an action";
icon = MessageBoxIcon.Information;
buttons = MessageBoxButtons.YesNo;
}
else
{
message = "Incomplete data";
title = "Error";
icon = MessageBoxIcon.Error;
buttons = MessageBoxButtons.OK;
}
}
else
{
message = "No data submitted";
title = "Error";
icon = MessageBoxIcon.Error;
buttons = MessageBoxButtons.OK;
}
this.DialogResult = MessageBox.Show(message, title, buttons, icon);
if (this.DialogResult == DialogResult.Yes) this.Close();
else this.OnFormClosing(new FormClosingEventArgs(CloseReason.None, true));
}
The problem is that the code will always get back to the calling method, thus closing (maybe just hiding?) the sub-form, even if the this.Close() method isn't called.
Thanks in advance.
you should not make a new event instance, those are things you would want to avoid
instead try:
DialogResult dialogResult = MessageBox.Show("Sure", "Some Title",
MessageBoxButtons.YesNo);
if(dialogResult == DialogResult.Yes)
{
Close();
}
Events are supposed to occur automatically, so 'OnFormClosing' will raise when the form will close.
also i recommend to use this.Close instead of Dispose
Form.Close() sends the proper Windows messages to shut down the win32 window. During that process, if the form was not shown modally, Dispose is called on the form. Disposing the form frees up the unmanaged resources that the form is holding onto.
for more organized code,
try making an instance of the form from the main form
and handle the dialog result like this:
using (SubForm form = new SubForm())
{
DialogResult dr = form.ShowDialog();
if(dr == DialogResult.Yes)
{
string studdToSave= form.StuffToSave;
SaveToFile(studdToSave);
}
}
I find it strange that you want to close the form when the user just wants to save the data. :)
Save should not close your form.
When you close the form, you should verify if there are unsaved changes.
If there are, ask the user the question if he wants to save his changes before closing and offer him the options Yes, No and Cancel, where Cancel means 'cancel closing the form'.
Depending on wether the user clicked Yes or No, you should or shouldn't save the changes.
If the user clicked cancel, you should cancel closing the form by having an event for the FormClosing event. This event allows you to cancel closing the form.
private void btnClose_Click(object sender, EventArgs e)
{
if (unsavedChanges)
{
var result = MessageBox.Show("Save changes?", "unsaved changes", MessageBoxButtons.YesNoCancel);
if (result == DialogResult.Yes)
{
SaveChanges();
}
if (result == DialogResult.Cancel)
{
cancelClose = true;
}
this.Close();
}
}
private void Form2_FormClosing(object sender, FormClosingEventArgs e)
{
e.Cancel = cancelClose;
cancelClose = false;
}
The code above is usefull when 'Form2' is not a modal form.
If you want Form2 to be shown modal, the code above will work as well. However, you can also use the DialogResult proprety of the Form in that case:
private void btnClose_Click(object sender, EventArgs e)
{
if (unsavedChanges)
{
var result = MessageBox.Show("Save changes?", "unsaved changes", MessageBoxButtons.YesNoCancel);
if (result == DialogResult.Yes)
{
SaveChanges();
}
if (result == DialogResult.Cancel)
{
result = DialogResult.None;
}
this.DialogResult = result;
}
}
I have created a program that contains (for now) 2 forms.
In the first form I am asking the user for a file. After the user has selected a file, another form is called followed by closing of the current form.
An if statement indicates if the user has inserted a file when the Open File button is pressed, and if not, the second form will not be loaded.
The problem is that if the user clicks the Close button on the first form (the current one), the form closes and the next one is called.
The options of the next form are based on the user's input in the first form (where the user is asked to select a file), so if the second form is called when the user cancels the first form, it will create problems for methods in the second form.
Any ideas about how to handle the Close Button?
If you want to prevent closing the form you can handle the event
bool cancel = true;
protected override void OnFormClosing(FormClosingEventArgs e)
{
e.Cancel = cancel;
base.OnFormClosing(e);
}
Remember to change cancel to false when it's done to close the form.
There is an event named "FormClosing" on forms.
A quick sample:
private void Form1_FormClosing(object sender, FormClosingEventArgs e)
{
if (MessageBox.Show("Are you sure you want to quit?", MessageBoxButtons.YesNo) == DialogResult.No)
{
e.Cancel = true;
}
}
I am assuming that you have an OpenfileDialog (to allow the user to select a file),and a button probably named Open File to pass the filename to next form.If this is the case,then you can try to to disable the open button if no file has been selected.
Consider the code below as the function where all logic takes place;
private void BrowseFile()
{
//dlgopenfile is the name of Openfiledialog that allows the user to browse for a file.
//string filename is the name of selected file if any.
//Form2 is the next form.
try
{
switch (dlgopenfile.ShowDialog())
{
case DialogResult.OK://If Ok(Yes) button is pressed on Openfiledialog.
filename = dlgopenfile.FileName;
break;
case DialogResult.Cancel://If Cancel button is pressed on Openfiledialog.
filename = "";
break;
}
if (filename.Length >= 1)
{
if (File.Exists(filename) == true)
{
ButtonOpenFile.Enabled = true;
}
else
{
ButtonOpenFile.Enabled = false;
throw new FileNotFoundException("The file you selected does not exist.");
}
}
}
catch (FileNotFoundException ex)
{
MessageBox.Show(ex.Message, "Form1", MessageBoxButtons.OK, MessageBoxIcon.Error);
}
}
The next function occurs if user tries to close the form in mid session.
private void Form1_FormClosing(object sender, FormClosingEventArgs e)
{
try
{
switch (MessageBox.Show("Do you want to exit ?", "Form1", MessageBoxButtons.YesNo, MessageBoxIcon.Asterisk))
{
case DialogResult.Yes:
this.Close();
break;
case DialogResult.No:
e.Cancel = true;
break;
}
}
catch (Exception)
{
//Exception handling code goes here.
}
}
Finally the function below calls Form2's constructor with the selected file as argument.
private void ButtonOpenFile_Click(object sender, EventArgs e)
{
//This Button is enabled only if the file has been selected and if its exists.
Form2 form2 = new Form2(filename);//filename is the name of selected file,as decided in function BrowseFile().
this.Close();//Close Form1.
form2.ShowDialog();//Show Form2 as modal dialog.
}
Hope it would help you achieve what you need.Anything more,please let me know.
Proposally you start you form with form.ShowDialog(), which returns DialogResult. You should check whether it is DialogResult.Ok or whether form.DialogResult != DialogResult.None. In the form, if the user inserts the file you can set the form.DialogResult explicitely to DialogResult.Ok
Just you can handle the close event with your own logic
private void Form1_FormClosing_1(object sender, FormClosingEventArgs e)
{
if (MessageBox.Show(text:"Are you sure you want to quit?",caption:string.Empty,buttons: MessageBoxButtons.YesNo) == DialogResult.No)
{
e.Cancel = true;
}
}
everyone.
I've run into such a problem. In my app, I show second form from my main form through ShowDialog method. In this form I have some textBox(s) to connect to the DB and a Connect button. If user clicks X, the app exit. But if user click "connect" - I connect to DB and also close my second form. To catch closing event I use FormClosing method where the app asks whether I'm about to close the app and if yes it exit. The problem is that when I click the button, FormClosing event fires and asks me if I want to exit. How to avoid it? I try to use sender, but it doesn't work.
Here is my code:
private void Connect_Click(object sender, EventArgs e)
{
try
{
orcl.connect(userID.Text, Password.Text, comboTNS.Text);
if (orcl.ifHasRows("select dbclass from setupdbversion where dbclass='SECURITY' and rownum=1"))
{//my stuff
this.Close();
}
}
catch (Exception ex)
{
MessageBox.Show(ex.Message.ToString());
};
}
private void SecConnForm_FormClosing_1(object sender, FormClosingEventArgs e)
{
MessageBox.Show(sender.ToString());
if (e.CloseReason == CloseReason.UserClosing)
{
MessageBox.Show(sender.ToString());
if (string.Equals((sender as Form).Name, #"SecConnForm")) //it doesn't work as in any cases the sender is my form, not a button (when i click on button of course)
{
if (MessageBox.Show(this, "Really exit?", "Closing...",
MessageBoxButtons.OKCancel, MessageBoxIcon.Question)
== DialogResult.Cancel)
e.Cancel = true;
else
Application.Exit();
}
else
{
//other stuff goes..
}
}
}
Form closing event will fire every time form is closed whether that is done by code or by user click.
What you need is something similar to this.
private boolean bFormCloseFlag = false;
private void Connect_Click(object sender, EventArgs e)
{
try
{
orcl.connect(userID.Text, Password.Text, comboTNS.Text);
if (orcl.ifHasRows("select dbclass from setupdbversion where dbclass='SECURITY' and rownum=1"))
{//my stuff
bFormCloseFlag = true;
this.Close();
}
}
catch (Exception ex)
{
MessageBox.Show(ex.Message.ToString());
};
}
private void SecConnForm_FormClosing_1(object sender, FormClosingEventArgs e)
{
if (bFormCloseFlag = false)
{
MessageBox.Show(sender.ToString());
if (e.CloseReason == CloseReason.UserClosing)
{
MessageBox.Show(sender.ToString());
if (string.Equals((sender as Form).Name, #"SecConnForm")) //it doesn't work as in any cases the sender is my form, not a button (when i click on button of course)
{
if (MessageBox.Show(this, "Really exit?", "Closing...",
MessageBoxButtons.OKCancel, MessageBoxIcon.Question)
== DialogResult.Cancel)
e.Cancel = true;
else
Application.Exit();
}
else
{
//other stuff goes..
}
}
}
}
This flag will simply check whether form is closed by 'X' button click or it is closed by your code.
The this.Close() triggers the closing type of "UserClosing"
Possibly just hide the dialog instead of this.close()?
I am using C# here. I have a form where the user can select Yes or No, and if they choose No, a message box appears and asks them if they are sure. If they click No, I want to show the form again. Here's my code:
public void function()
{
MyForm form = new MyForm();
if (form.ShowDialog() == DialogResult.No)
{
if (MessageBox.Show("Are you sure?",
MessageBoxButtons.YesNo) == DialogResult.Yes)
{
runFinished.Dispose();
return;
}
else
{
//Show form again. How??
}
}
}
Thanks everybody for your help!
Arrange that the No button MyForm does the call to MessageBox. Only if the user is sure do you then go on to close the dialog. Your current approach of asking the question after the dialog has closed is incorrect.
You can effect the change by making sure that DialogResult is set in code rather than by the No button's DialogResult property. Then in the click handler for the button you run the message box. If the user confirms the action, then set the forms DialogResult to DialogResult.No.
Call two events depending on whether no or yes is selected (within MyForm). For example
void OnNoEvent(object sender, EventArgs e)
{
if (MessageBox.Show("Are you sure?", MessageBoxButtons.YesNo) == DialogResult.Yes)
{
this.DialogResult = DialogResult.No;
this.Close();
}
}
void OnYesEvent(object sender, EventArgs e)
{
this.DialogResult = DialogResult.Yes;
this.Close();
}
This is probably better than opening the dialog box many times.
Then the code to open the dialog is easy.
MyForm form = new MyForm();
if (form.ShowDialog() == DialogResult.No)
// perform actions here
There is the standart means: Form.FormClosing.
See example: example
Maybe I am missing something here, but why not use a while loop?
public void function()
{
MyForm form = new MyForm();
while(form.ShowDialog() == DialogResult.No)
{
if (MessageBox.Show("Are you sure?",
MessageBoxButtons.YesNo) == DialogResult.Yes)
{
runFinished.Dispose();
return;
}
}
}