Please help, I'm confused I do not know why the error logs
System.StackOverflowException was unhandled.
I keep getting an error on set LekID.
How would I that fix?
Here is the code:
public Lager(long lekID, string lek, string proizvojdac, int kolicina, double cena)
{
LekID = lekID;
Lek = lek;
Proizvodjac = proizvojdac;
Kolicina = kolicina;
Cena = cena;
}
public long LekID
{
get { return LekID; }
set { LekID = value; }
}
public string Lek
{
get { return Lek; }
set { Lek = value; }
}
public string Proizvodjac
{
get { return Proizvodjac; }
set { Proizvodjac = value; }
}
public int Kolicina
{
get { return Kolicina; }
set { Kolicina = value; }
}
public double Cena
{
get { return Cena; }
set { Cena = value; }
}
public long LekID
{
get { return LekID; }
set { LekID = value; }
}
This (and the other properties) cause a StackOverflowException, since you are assigning value to LekID over and over again.
You should add a field to the property and store the value there:
private long _lekID;
public long LekID
{
get { return _lekID; }
set { _lekID = value; }
}
You should give different names to your private variables and to your properties. Otherwise, your property is calling itself when you access it.
Example:
long _lekID;
public long LekID
{
get { return _lekID; }
set { _lekID = value; }
}
Or simply:
public long LekID { get; set; }
The properties are calling themself. Try changing your properties like this:
public string Lek
{
get;
set;
}
You're calling the Lek property recursively in both the setter and the getter
Either introduce a backing field:
private string lek;
public string Lek
{
get { return this.lek; }
set { this.lek = value; }
}
or use an Automatic Property:
public string Lek
{
get; set;
}
Marking this community wiki as it is only an aside, but none of this would have happened if you'd been sufficiently lazy (that is often a virtue in programming, not a vice):
public long LekID {get;set;}
public string Lek {get;set;}
public string Proizvodjac {get;set;}
public int Kolicina {get;set;}
public double Cena {get;set;}
less typing; no errors; and you've correctly exposed the API as properties so you can add validation / side-effects later if you need, and it'll work with binding APIs (which don't usually love fields).
Try using code snippet like prop/ propfull,
the snippets will create the properties code automaticly
Related
When accessing the property using the getter i'm getting a NULL. I've changed it to public to test if everything else is working and yeah nothing else is wrong.
HTProvince Class
public string provinceCode;
public string ProvinceCode
{
get; set;
}
Form
public Form1()
{
//HTGetProvinces() returns a list of provinces
InitializeComponent();
List<HTProvince> provinceList =
HTProvince.HTGetProvinces();
foreach (HTProvince x in provinceList)
{
//Works. Adds items the province code property of for each item to my list
provincesListBox.Items.Add(x.provinceCode);
//throws null exception. Doesn't work
provincesListBox.Items.Add(x.ProvinceCode);
}
}
That is a bad practice. You have to make your field 'provinceCode' to private
private string provinceCode;
Your property has to be only public
Which can only be access.
public string ProvinceCode
{
get
{
return provinceCode;
}
set
{
provinceCode = value;
}
}
public Form1()
{
//HTGetProvinces() returns a list of provinces
InitializeComponent();
List<HTProvince> provinceList =
HTProvince.HTGetProvinces();
foreach (HTProvince x in provinceList)
{
//Works. Adds items the province code property of for each item to my list
provincesListBox.Items.Add(x.ProvinceCode);
}
}
That is right behaviour, you have not return any value for this property or set value so it is null.
public string ProvinceCode
{
get; set;
}
if you want to return the provinceCode
private string provinceCode;
public string ProvinceCode
{
get
{
return provinceCode;
}
set
{
provinceCode = value;
}
}
If you want to have some default value if ProvinceCode is not set you could use lazy loading:
private string _provinceCode;
public string ProvinceCode
{
get
{
if(string.IsNullOrEmpty(_provinceCode)) {
_provinceCode = "CODE";
}
return _provinceCode;
}
set
{
_provinceCode = value;
}
}
This is auto-properties introduced in C# 3.0 and later
Change the property to:
private string provinceCode { get; set; }
Instead of a separate method:
public string ProvinceCode
{
get; set;
}
Is there a standard naming convention for the properties/methods of a node/relationship class when working with Neo4jClient?
I'm following this link Neo4jClient - Retrieving relationship from Cypher query to create my relationship class
However, there are certain properties of my relationship which i can't get any value despite the relationship having it. While debugging my code, i realized certain properties was not retrieved from the relationship when creating the relationship object.
this is my relationship class
public class Creates
{
private string _raw;
private int _sourcePort;
private string _image;
private int _DestinationPort;
private int _eventcode;
private string _name;
private string _src_ip;
private int _src_port;
private string _dvc;
private int _signature_ID;
private string _dest_ip;
private string _computer;
private string _sourceType;
private int _recordID;
private int _processID;
private DateTime _time;
private int _dest_port;
public string Raw { get { return _raw; } set { _raw = value; } }
public int SourcePort { get { return _sourcePort; } set { _sourcePort = value; } }
public string Image { get { return _image; } set { _image = value; } }
public int DestinationPort { get { return _DestinationPort; } set { _DestinationPort = value; } }
public int Eventcode { get { return _eventcode; } set { _eventcode = value; } }
public string Name { get { return _name; } set { _name = value; } }
public string Src_ip { get { return _src_ip; } set { _src_ip = value; } }
public int Src_port { get { return _src_port; } set { _src_port = value; } }
public string DVC { get { return _dvc; } set { _dvc = value; } }
public int Signature_ID { get { return _signature_ID; } set { _signature_ID = value; } }
public string Dest_ip { get { return _dest_ip; } set { _dest_ip = value; } }
public string Computer { get { return _computer; } set { _computer = value; } }
public string SourceType { get { return _sourceType; } set { _sourceType = value; } }
public int RecordID { get { return _recordID; } set { _recordID = value; } }
public int ProcessID { get { return _processID; } set { _processID = value; } }
public DateTime Indextime { get { return _time; } set { _time = value; } }
public int Dest_port { get { return _dest_port; } set { _dest_port = value; } }
}
This is another class
public class ProcessConnectedIP
{
public Neo4jClient.RelationshipInstance<Pivot> bindto { get; set; }
public Neo4jClient.Node<LogEvent> bindip { get; set; }
public Neo4jClient.RelationshipInstance<Pivot> connectto { get; set; }
public Neo4jClient.Node<LogEvent> connectip { get; set; }
}
This is my neo4jclient query to get the relationship object
public IEnumerable<ProcessConnectedIP> GetConnectedIPs(string nodeName)
{
try
{
var result =
this.client.Cypher.Match("(sourceNode:Process{name:{nameParam}})-[b:Bind_IP]->(bind:IP_Address)-[c:Connect_IP]->(connect:IP_Address)")
.WithParam("nameParam", nodeName)
.Where("b.dest_ip = c.dest_ip")
.AndWhere("c.Image=~{imageParam}")
.WithParam("imageParam", $".*" + nodeName + ".*")
.Return((b, bind, c, connect) => new ProcessConnectedIP
{
bindto = b.As<RelationshipInstance<Creates>>(),
bindip = bind.As<Node<LogEvent>>(),
connectto = c.As<RelationshipInstance<Creates>>(),
connectip = connect.As<Node<LogEvent>>()
})
.Results;
return result;
}catch(Exception ex)
{
Console.WriteLine("GetConnectedIPs: Error Msg: " + ex.Message);
return null;
}
}
This is the method to read the results
public void MyMethod(string name)
{
IEnumerable<ProcessConnectedIP> result = clientDAL.GetConnectedIPs(name);
if(result != null)
{
var results = result.ToList();
Console.WriteLine(results.Count());
foreach (ProcessConnectedIP item in results)
{
Console.WriteLine(item.Data.Src_ip);
Console.WriteLine(item.bindto.StartNodeReference.Id);
Console.WriteLine(item.bindto.EndNodeReference.Id);
Console.WriteLine(item.connectto.StartNodeReference.Id);
Console.WriteLine(item.connectto.EndNodeReference.Id);
Node<LogEvent> ans = item.bindip;
LogEvent log = ans.Data;
Console.WriteLine(log.Name);
Node<LogEvent> ans1 = item.connectip;
LogEvent log1 = ans1.Data;
Console.WriteLine(log1.Name);
}
}
}
Somehow, i'm only able to populate the relationship object with src_ip/src_port/dest_ip/dest_port values. the rest are empty.
Is there any possible reason why? I've played with upper/lower cases on the properties names but it does not seem to work.
This is the section of the graph im working with
This is the relationship properties sample:
_raw: Some XML dataSourcePort: 49767Image: C:\Windows\explorer.exeDestinationPort: 443EventCode: 3Name: Bind
IPsrc_ip: 172.10.10.104dvc: COMPUTER-NAMEsrc_port:
49767signature_id: 3dest_ip: 172.10.10.11Computer:
COMPUTRE-NAME_sourcetype:
XmlWinEventLog:Microsoft-Windows-Sysmon/OperationalRecordID:
13405621ProcessId: 7184_time: 2017-08-28T15:15:39+08:00dest_port: 443
I'm not entirely sure how your Creates class is ever populated, in particular those fields - as your Src_port property doesn't match the src_port in the sample you provided (case wise).
I think it's probably best to go back to a super simple version. Neo4jClient will map your properties to the properties in the Relationship as long as they have the same name (and it is case-sensitive).
So start with a new Creates class (and use auto properties - it'll make your life a lot easier!)
public class Creates
{
public string Computer { get; set; }
}
Run your query with that and see if you get a result, then keep on adding properties that match the name and type you expect to get back (int, string etc)
It seems that i have to give neo4j node/relationship property names in lowercase and without special characters at the start of the property name, in order for the above codes to work.
The graph was not created by me at the start thus i had to work on it with what was given. I had to get the developer who created the graph to create the nodes with lowercases in order for the above to work.
I have a class called Assign and
private int SeatNumber;
public Assign(int SeatNum)
{
SeatNumber = SeatNum;
}
public int SeatNumber
{
get { return SeatNumber; }
set { SeatNumber = value; }
}
I have no idea why I am getting the following error
EThe type 'WindowsFormsApplication1.Assign' already contains a definition for 'SeatNumber'
What is wrong?
You're declaring the same variable twice here.
private int SeatNumber;
public int SeatNumber
{
get { return SeatNumber; }
set { SeatNumber = value; }
}
That code defines the same variable twice. If you're using .net 3.0+, you can do auto-implemented properties like this with no private int SeatNumber:
public int SeatNumber
{
get;
set;
}
otherwise, you should do this:
private int SeatNumber_;
public int SeatNumber
{
get { return SeatNumber_; }
set { SeatNumber_ = value; }
}
You should make sure that the variable that backs the property has a different name. It is common to use camelCase for it:
private int seatNumber;
public Assign(int SeatNum)
{
SeatNumber = SeatNum;
}
public int SeatNumber
{
get { return seatNumber; }
set { seatNumber = value; }
}
Moreover, in situations where the getter ans setter are trivial, starting with C# 3.0 you can use automatic properties, like this:
public int SeatNumber {get; set;}
This lets you remove the backing variable: the compiler will take care of it for you.
The private and public variables can't have the same name, that is where the conflict is coming from. Do this:
private int _seatNumber;
public Assign(int SeatNum)
{
SeatNumber = SeatNum;
}
public int SeatNumber
{
get { return _seatNumber; }
set { _seatNumber = value; }
}
The underscore notation is common for private variables.
The error is thrown because you're basically assigning something to SeatNumber in the constructor and then doing it again in the property. When creating class fields in Visual Studio, type 'propfull' and hit the tab key twice. This will auto create the field and property for you.
For what it's worth, this is the generally accepted way to structure classes.
class Assign
{
//Fields
private int _seatNumber;
//Properties
public int SeatNumber
{
get { return _seatNumber; }
set { _seatNumber = value; }
}
//Overloaded Constructors
public Assign(int sn)
{
SeatNumber = sn;
}
public Assign()
{
}
//Methods
public void SomeMethod()
{
//insert code
}
public void SomeOtherMethod()
{
//insert code
}
}//END ASSIGN CLASS
Below is what I get shortly before VS Debugger crashes. When i don't have the debugger view it, it throws a segfault in the set function. The debugger has been working all day, on this same stuff too. Any ideas?
Object i am viewing:
[DataContract]
public class SvnUrl
{
public string _type;
public string _acronym;
public string _location;
public string _url;
public int _foundstatus;
[DataMember]
public string type
{
get { return _type; }
set { _type = value; }
}
[DataMember]
public string acronym
{
get { return _acronym; }
set { _acronym = value; }
}
[DataMember]
public string location
{
get { return _location; }
set { _location = value; }
}
[DataMember]
public string url
{
get { return _url; }
set { _url = value; }
}
[DataMember]
public int foundstatus
{
get { return _foundstatus; }
set { _foundstatus = value; }
}
}
Are you sure you typed the example identical to your code and you don't really have get { return location; } in that location property (note the missing _ thus recursing infinitely)?
So, I got to work on this huge project. And the is this HUGE class with hundreds of variables and methods and lots of partial classes.
interface IBusinessReturn
{
string variableOne { get; set; }
string variableTwo { get; set; }
string variableHundred { get; set; }
//a lot more...
}
public partial class BusinessTransaction : IBusinessReturn
{
private string _variableOne;
public string variableOne
{
get { return variableOne; }
set { _variableOne= value; }
}
private string _variableTwo;
public string variableTwo
{
get { return variableTwo; }
set { _variableTwo = value; }
}
private string _variableHundred;
public string variableHundred
{
get { return variableHundred; }
set { _variableHundred = value; }
}
// And so it goes on till hundreds...
}
And lots of other partials that goes like this:
public partial class BusinessTransaction: IBusinessTransaction238
{
//Lots of methods
}
The problem is: It is all working except for some new variables I declared. (varOne and Two, in the example above). When I try to set any value to these var I got a StackOverflowException. I'm 100% sure they're declared just like every other.
This is how i'm calling:
BusinessTransaction v763 = new BusinessTransaction();
v763.variableHundred = "Hi"; //working
v763.variableOne = "Hello"; //StackOverflow HERE.
I just can't see any reason for why this is happening, and I only hope you can tell me if this have something to do with the huge amount of methods and variables on this class..
Look at your getter - no underscores for any of them. You're causing an infinite loop.
public string variableOne
{
get { return variableOne; }
set { _variableOne= value; }
}
It should return private member, not itself.
Should be
public string variableOne
{
get { return _variableOne; // error was here
}
set { _variableOne= value; }
}